Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the callback url #153

Merged
merged 1 commit into from
Feb 5, 2024
Merged

correct the callback url #153

merged 1 commit into from
Feb 5, 2024

Conversation

cboettig
Copy link
Contributor

Fix for project-zot/zot#2191

Callback URL syntax path is incorrect, misses the zot/. Correct path is given in: https://github.com/project-zot/zot/blob/9def35f3b8b38f5a438146a09087edcec00537c7/examples/README.md?plain=1#L294

What type of PR is this?

documentation

Which issue does this PR fix:

Fix for project-zot/zot#2191

What does this PR do / Why do we need it:

Callback URL is incorrect in docs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andaaron
Copy link
Contributor

andaaron commented Jan 30, 2024

Thank you for the contribution.
The diff looks good, please make these changes to the commit and push again:

git commit --amend -s -S to prepend docs: to the first line of the commit message, add the signoff email and GPG sign the commit.

@rchincha
Copy link
Contributor

@cboettig pls address the CI failures.

@cboettig
Copy link
Contributor Author

cboettig commented Feb 4, 2024

sorry for the delay, my signing key expired so I had to retrieve the offline master key to renew my subkey, oof 🔒 let me know if that fixes the commit formatting and thanks @andaaron for the clear instructions!

@andaaron
Copy link
Contributor

andaaron commented Feb 4, 2024

sorry for the delay, my signing key expired so I had to retrieve the offline master key to renew my subkey, oof 🔒 let me know if that fixes the commit formatting and thanks @andaaron for the clear instructions!

Hi, the process itself was ok, but it seems there's a mismatch between the names used:
sign-off not found for commit author: Carl Boettiger [email protected]; found: ['Carl <[email protected]>']

Is the git user.name setting the same as the one configured for GPG?

@cboettig
Copy link
Contributor Author

cboettig commented Feb 4, 2024

thanks fixed.

@andaaron andaaron merged commit e108fb4 into project-zot:main Feb 5, 2024
3 of 4 checks passed
@andaaron andaaron linked an issue Feb 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Typos in website directions for auth?
3 participants